lib/src/room.dart (2)

210-218: ⚡ Quick win

Redundant variable read for directChatMatrixID.

directChatMatrixID is already read at line 202 and can be reused here instead of re-reading it at line 212.

♻️ Refactor to reuse the variable from line 202

     if (heroes == null) return [];
 
-    // Filter out functional members (bots/bridges) when in a DM room,
-    // so that hero user loading only fetches the real human participant.
-    final directChatMatrixID = this.directChatMatrixID;
-    if (directChatMatrixID != null) {
+    // Filter out functional members (bots/bridges) when in a DM room,
+    // so that hero user loading only fetches the real human participant.
+    if (directChatMatrixID != null) {
       final fMembers = functionalMembers;
       if (fMembers.isNotEmpty) {
         heroes = heroes.where((h) => !fMembers.contains(h)).toList();
       }
     }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/src/room.dart` around lines 210 - 218, The code redundantly re-reads
directChatMatrixID; reuse the previously read directChatMatrixID variable (from
earlier in the function) instead of re-evaluating it here—locate the existing
directChatMatrixID declaration and use that reference in the conditional that
filters out functionalMembers from heroes (keep the functionalMembers and heroes
logic unchanged), removing the extra read to eliminate redundancy.

---

391-404: ⚡ Quick win

Consider using tryGetList for consistency with codebase patterns.

The current implementation manually checks the type and filters, but the codebase has a tryGetList extension method (see lib/matrix_api_lite/utils/try_get_map_extension.dart) for extracting typed lists from event content.

♻️ Use tryGetList for idiomatic list extraction

   List<String> get functionalMembers {
-    final event = getState('io.element.functional_members');
-    final serviceMembers = event?.content['service_members'];
-    if (serviceMembers is List) {
-      return serviceMembers.whereType<String>().toList();
-    }
-    return [];
+    return getState('io.element.functional_members')
+            ?.content
+            .tryGetList<String>('service_members', TryGet.silent) ??
+        [];
   }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/src/room.dart` around lines 391 - 404, Replace the manual
type-check/filter in the Room.functionalMembers getter with the project's
tryGetList helper: fetch the state event via
getState('io.element.functional_members'), then call
event?.content.tryGetList('service_members') (or the appropriate extension
import) and return that result (or [] if null) so the extraction is consistent
and idiomatic with other code using tryGetList.

test/room_test.dart (1)

1098-1103: ⚡ Quick win

Strengthen negative test assertion.

The negative case uses isNot('John Doe') to verify the bot appears when io.element.functional_members is absent. This assertion is weak because it would pass for any result that isn't exactly "John Doe" (e.g., empty string, error message).

A stronger assertion would explicitly check that the bot's display name appears alongside the real user.

💪 Stronger assertion

-        // Without functional_members, the bot appears alongside the real user
-        expect(
-          dmRoomNoFilter.getLocalizedDisplayname(),
-          isNot('John Doe'),
-          reason:
-              'Without io.element.functional_members, bot should still appear in room name',
-        );
+        // Without functional_members, the bot appears alongside the real user
+        final displayName = dmRoomNoFilter.getLocalizedDisplayname();
+        expect(
+          displayName.contains('Signal Bridge Bot') || displayName.contains('signal-bot'),
+          true,
+          reason:
+              'Without io.element.functional_members, bot should appear in room name',
+        );

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/room_test.dart` around lines 1098 - 1103, The negative assertion using
isNot('John Doe') is too weak; update the test around
dmRoomNoFilter.getLocalizedDisplayname() to explicitly assert that the returned
display name contains both the bot's display name and the real user's name
(e.g., use contains matchers or a regex against getLocalizedDisplayname() to
verify presence of the bot label and "John Doe"), so that the test guarantees
the bot appears alongside the real user rather than merely not equaling "John
Doe".